Fix tests against ember >=4
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest beta of Ember v4 now includes ember-auto-import `>=2` as a dependency, forcing the consuming application to include it as well. As a side-effect of that, we can’t run our test suite against `v4` unless we also add ember-auto-import to our dependencies, again forcing apps downstream to do the same. We don’t use any of the features of auto-import, so it feels rather silly dropping a major version over this. Luckily, we can use ember-try scenarios to work around this!
sandydoo
added a commit
that referenced
this pull request
Oct 13, 2021
emberjs/ember.js#19761 (comment) Apparently, we can add auto-import `>= 2` to our devDependencies without *crosses fingers* any issue...as long as we don’t need it in our addon code. This is a partial revert for PR #153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest beta of Ember v4 now includes ember-auto-import
>=2as a dependency, forcing the consuming application to include it as well. As a side-effect of that, we can’t run our test suite againstv4unless we also add ember-auto-import to our dependencies, again forcing apps downstream to do the same.We don’t use any of the features of auto-import, so it feels rather silly dropping a major version over this. Luckily, we can use ember-try scenarios to work around this!