Removed unnecessary instances and simplified LogProviders + RuntimeOptions #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve logging and workflow behavior. The most important changes involve replacing the
LogProvider
withWhisperLogger
and ensuring that test result files are uploaded regardless of test success or failure.Logging Improvements:
LogProvider.Log
withWhisperLogger.Log
inCudaHelper.cs
,NativeLibraryLoader.cs
, andRuntimeOptions.cs
to standardize logging. [1] [2] [3] [4] [5] [6] [7] [8]LogProvider
to be a static class and moved logging logic to a new internalWhisperLogger
class. [1] [2] [3]LogProvider.AddLogger
which now returns an IDisposable for easy cleanup instead of using events.Workflow Enhancements:
.github/workflows/dotnet.yml
to upload trx files even if the previous step fails, ensuring test results are always available. [1] [2] [3]Configuration Improvements:
RuntimeOptions
from an instance-based class to a static class, simplifying the configuration of runtime options. [1] [2]Example Update:
WhisperLogger
for logging.