Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix guard signal #489

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Bugfix guard signal #489

merged 3 commits into from
Sep 19, 2024

Conversation

sserita
Copy link
Contributor

@sserita sserita commented Sep 19, 2024

Small bugfixes:

  • Guarding setting SIGINT via signal in the customlm code. Needed in order to use pyGSTi with some external parallelization frameworks, such as Dask.
  • Fixing unit tests by including a Label.is_simple() to Label.IS_SIMPLE that was missed.

@sserita
Allow SIGINT set to be skipped via env variable.
e670aeb 
This is relevant when attempting to use Dask outside of pyGSTi,
where signals cannot be set in the workers.
Setting the PYGSTI_NO_CUSTOMLM_SIGINT env variable
now skips this behavior.
@sserita
Logic bugfix
f93fd3c
@sserita
Bugfix for deterministic Clifford RB test.
db5f4b4 
Fix was a missing Label.is_simple() -> Label.IS_SIMPLE.
@sserita sserita added this to the 0.9.13 milestone Sep 19, 2024
@sserita sserita requested review from rileyjmurray and a team as code owners September 19, 2024 16:46
@sserita sserita merged commit c1f97f8 into develop Sep 19, 2024
4 checks passed
@sserita sserita deleted the bugfix-guard-signal branch September 19, 2024 16:48
sserita added a commit that referenced this pull request Sep 19, 2024
@sserita
Merge branch 'develop' into bugfix-model-parameters
f16e5f6 
Performing this pre-PR merge since this could have potentially
conflicted with fixes from #488 for parameter_labels
and #489 for IS_SIMPLE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjmurray rileyjmurray Awaiting requested review from rileyjmurray rileyjmurray is a code owner

@coreyostrove coreyostrove Awaiting requested review from coreyostrove coreyostrove is a code owner automatically assigned from sandialabs/pygsti-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.13
Development

Successfully merging this pull request may close these issues.
1 participant
@sserita