-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature BiRB #348
Feature BiRB #348
Conversation
Hey @jordanh6 , great work! Regarding the failing unit tests, this is due to the installation failing on newer versions of python. This is a related to a dependency bug (not of our own doing) that was fixed in the latest release. If you merge 'develop' into this branch that should fix that issue and get the tests at least to the point of actually running again. Let me know if you'd prefer me to do so on your behalf. |
There looks to be a change in ibmqcore.py (commenting out an IBM backend related check) that might be a holdover from some testing you were doing. Is that change intentional? Great work on adding detailed docstrings throughout the new code. There are a couple of new methods that were added to the SummaryStatistics class in vb.py, Elephant in the room now (I'll save @sserita from having to be the bad guy this time around), we need to add some unit testing for these new modules. This can be a bit confusing the first time around with needing to understand the syntax/modules used for testing, but once you've made some once it isn't actually so bad. I'd be happy to go through this process with you and help write these new tests. |
Thanks! Also, thanks to @dhothem for writing a large portion of the code and documentation. I think I resolved everything except writing unit tests. I'll happily take you up on your offer to help @coreyostrove !
|
This commit adds new unit tests targeting the construction of BiRB experiment designs as well as running the protocol and some basic checks for correct output in the ideal case. This commit also plugs holes in the previously existing set of unit tests for the remaining RB protocols (CRB, DRB, MRB) and adds tests for running those protocols (previously only the experiment design creation was being tested for these protocols). Finally, a new test was added for the q_elimination sampling method for RB circuit construction.
With the new unit tests added (including some bonus ones extending our coverage for other parts of the RB codebase) and the last couple changes to the code addressing some edge cases from @jordanh6 this all looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for your work on this, I think it looks great! Really appreciate the unit tests and tutorial updates! :)
This PR primarily adds the code for running Binary RB (BiRB). Notable other changes: