-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPR Bugfixes and Feature Enhancements #261
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0f2c098
Merge branch 'develop' of https://github.com/pyGSTio/pyGSTi into develop
2895481
First pass at reworker per-germ-L fpr (not working still).
sserita a4447b7
Merge branch 'develop' into bugfix-fpr-pgl-params
0df3a1d
Updates EigenvalueParamDenseOp so that n x n degenerate blocks are pa…
a00b1b8
Updates the per-germ-per-L FPR algorithm to test eigenvalue magnitude…
95a7b13
Updates unit tests to match updated germ selection routine.
7016a05
Updates a system test for recent per-germ-per-L FPR changes.
9dfccb7
Merge branch 'develop' into bugfix-fpr-pgl-params
30f7fc8
Merge branch 'develop' into bugfix-fpr-pgl-params
bc32079
Updated the per-germ power fpr algorithm to use relative tolerances b…
65ae161
Merge branch 'bugfix-fpr-pgl-params' of https://github.com/pyGSTio/py…
a33c187
Bugfix for the fisher information by L calculation which adds in the …
666b78c
Simple fix for logic on when to add in the additional circuits.
a8c0ab3
Refinements to the per-germ FPR algorithm that add the ability to sea…
ff9f2fc
Compatibility fixes for per-germ power FPR. More updates needed to br…
c8e9862
Edge cases when there are collisions between eigenvalues
2a582e5
Revert "Edge cases when there are collisions between eigenvalues"
a0a1b83
Edge cases when there are collisions between eigenvalues
d0bd0d3
Fix parameter counting for minimum number of fiducial pairs needed.
cda8c52
Update per-germ FPR docstring
5753273
Remove condition number thresholding
deb8a27
Minor Typo Fix
dad9205
Merge branch 'develop' into bugfix-fpr-pgl-params
coreyostrove dd8fe0b
Minor Typo Fix
053c3de
Unit test fixes
6c9d757
More unit test fixes
a077146
Yet more unit test updates
26e2bb6
Changes to logging
fdb5ce9
Unit test updates
1c4aba7
Logging fix
3bf5e48
Move rank test earlier
758d444
Update kwargs in FPR tutorial notebook
1654a70
Try to patch the FPR unit tests on windows
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just bookmarking for us, but we may want to deprecate/underemphasize global FPR... It's slow and not any better than per-germ.