Skip test and add comment explaining why

sandialabs · Jan 23, 2023 · 0f8b7ca · 0f8b7ca
1 parent 2902035
commit 0f8b7ca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/core/unit_test/TestViewAPI.hpp b/core/unit_test/TestViewAPI.hpp
@@ -1542,7 +1542,6 @@ class TestViewAPI {
   }
 
   static void run_test_error() {
-#if !((HIP_VERSION_MAJOR == 5) && (HIP_VERSION_MINOR == 3))
 #ifdef KOKKOS_ENABLE_OPENMPTARGET
     if (std::is_same<typename dView1::memory_space,
                      Kokkos::Experimental::OpenMPTargetSpace>::value)
@@ -1587,7 +1586,6 @@ class TestViewAPI {
       }
 #endif
     }
-#endif
   }
 };
 

diff --git a/core/unit_test/TestViewAPI_d.hpp b/core/unit_test/TestViewAPI_d.hpp
@@ -26,8 +26,11 @@ TEST(TEST_CATEGORY, view_api_d) {
   TestViewAPI<double, TEST_EXECSPACE>::run_test_view_operator_c();
 }
 
+// ROCm 5.3 segfaults when trying to allocate too much memory
+#if !((HIP_VERSION_MAJOR == 5) && (HIP_VERSION_MINOR == 3))
 TEST(TEST_CATEGORY, view_allocation_error) {
   TestViewAPI<double, TEST_EXECSPACE>::run_test_error();
 }
+#endif
 
 }  // namespace Test