-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the use of YAML in Albany #21
Comments
Yes, I should research this YAML issue. I'm told that you can enable a YAML parser for Teuchos. |
If we find that YAML is a viable input option, one thing that will be especially useful will be an XML to YAML converter. |
The Teuchos YAML parser function defined here in Trilinos Seems to mirror the function used here in Albany: I've used the Teuchos YAML parser before and it is quite nice. Some things to consider:
|
@ibaned regarding https://github.com/gahansen/Albany/issues/21#issuecomment-276855421, I have investigated this issue. I tried to create a converter. The Teuchos ParameterList class has readers for both XML and YAML. There is a writer for XML but not for YAML (I was fooled by seeing that there is a declaration for the YAML writer but there is no implementation!). Not sure at this point what is the best way to proceed. Since the structure of the input files is very well defined and doesn't require all the syntax elements of either XML or YAML, I toyed with the idea of creating a simple parser to write a converter. But I just don't have time right now to play with this. |
@bgranzow regarding https://github.com/gahansen/Albany/issues/21#issuecomment-276998780, @ibaned seems to have fixed this. See #74. |
@lxmota @bgranzow I've recently done a lot of work to make YAML support complete enough for Albany's use cases. The result is pull request trilinos/Trilinos#1112. This adds support for TwoDArray input and output, and improve the API so that it can operate on any C++ stream. There was a YAML writer, I just made it more general and added TwoDArray support. There is also a function So, once trilinos/Trilinos#1112 gets accepted and we agree to depend on |
@ibaned @bgranzow https://github.com/gahansen/Albany/issues/21#issuecomment-285140886 |
The reverse conversion should be trivial to implement, both formats have read and write implemented. |
@ibaned Ha! I just logged in to give it a try to write the converters and I see this commit! Thanks! |
yaml-cpp, git and cmake in preparation for switching LCM to YAML input. [#21, #22]
conflicts on the SEMS environment when YAML is specified. Boost is loaded automatically as it is a dependency. [#21, #22]
Everything else is in place, waiting on Trilinos develop->master. |
@ibaned Thanks for your hard work on this. This is a big usability improvement. Who would be in charge of merging Trilinos develop to master? Maybe we can give them a nudge. |
I believe the current lag may be due to the Trilinos framework team working on trilinos/Trilinos#1154, which I think is great because once the system is automated we should see much more frequent merges from develop to master, and less frequent merges that break master. I would contact the people mentioned in that issue for updates. |
The Trilinos merge has happened ! I've enabled the YAML converters, we are free to move forward here. I recommend we close this issue as it represents putting in place the machinery necessary to use YAML. We can create other issues to track progress in converting test problems over to YAML, or for accepting YAML as a required dependency. |
Dave and Coleman has done some work for the crystal plasticity model, Chris S. has also worked on YAML.
The text was updated successfully, but these errors were encountered: