Upgrade BrainGlobe Atlas API package name #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print out user-defined parameters, similar to output in SimpleITK mode.
Image filenames generated from transformations such as rescaling have required using the `--prefix` CLI argument to load registered images. Since these filenames have suffixes from the transformation, the filenames can be deconstructed to set this prefix value.
- Support the package name change while continuing to support the old package - Install this package by default
yoda-vid
added
enhancement
Fall back to older `bg-atlasapi` package.
yoda-vid
added a commit
that referenced
this pull request
May 29, 2024
yoda-vid
added a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
brainglobe atlas APIwas renamed frombg-atlasapitobrainglobe-atlasapi(see brainglobe/brainglobe-atlasapi#176), including both the package name the corresponding top-level namespace. Setup now installs this new package, which updates versions from v1 to v2.To add a couple registration but otherwise unrelated changes, this PR includes a couple other changes:
my_image_scale0pt1format with registered images output tomy_image. This avoid the need to use the--prefixflag when loading the image, though the flag is still needed when registering the image.