-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal Error Component + Co-op in first/last semester bug #799
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const coopErr = | ||
course.name === COOP_TITLE && | ||
term !== undefined && | ||
(term.id === FALL_1 || term.id === SPRING_4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do they have to be hard coded? what if they have 5 years?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Adds a new error component for the error modal, which is general and can be reused for other errors. This PR renders the error component when trying to place Co-op classes in the Fall of your first semester or Spring of your last semester.
Closes #791
Type of change
Please tick the boxes that best match your changes.
yarn install
yarn dev:migration:run
How Has This Been Tested?
Checklist: