remove ‘takeWhile’ and ‘dropWhile’ #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
force-pushed
the
davidchambers/unsound
branch
from
1b5de74 to
e544b16
Compare
|
Makes sense to me. Does anyone know of important non-array usages of takeWhile that would be broken by this? |
|
@davidchambers I think this is the best option ATM. |
masaeedu
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are unsound, as explained in #122. Given that it may take us a long time to reformulate these functions, I propose the following actions:
Z.takeWhileandZ.dropWhile.[email protected].S.takeWhileandS.dropWhileto(a -> Boolean) -> Array a -> Array a.[email protected].There will be one breaking change to each project; this two-phase approach is no more disruptive than merging #122 immediately would have been.