Merge pull request #88 from sanctuary-js/davidchambers/lte

fix handling of NaN in Number$prototype$lte to guarantee totality
sanctuary-js · Feb 28, 2018 · f758e17 · f758e17
2 parents 2403d09 + b932b19
commit f758e17
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -668,7 +668,7 @@
   function Number$prototype$lte(other) {
     return typeof this === 'object' ?
       lte(this.valueOf(), other.valueOf()) :
-      isNaN(this) && isNaN(other) || this <= other;
+      isNaN(this) || this <= other;
   }
 
   //  Date$prototype$toString :: Date ~> () -> String

diff --git a/test/index.js b/test/index.js
@@ -683,7 +683,7 @@ test('lte', function() {
   eq(Z.lte(Infinity, -Infinity), false);
   eq(Z.lte(-Infinity, Infinity), true);
   eq(Z.lte(-Infinity, -Infinity), true);
-  eq(Z.lte(NaN, Math.PI), false);
+  eq(Z.lte(NaN, Math.PI), true);
   eq(Z.lte(Math.PI, NaN), false);
   eq(Z.lte(new Number(0), new Number(0)), true);
   eq(Z.lte(new Number(0), new Number(-0)), true);
@@ -694,7 +694,7 @@ test('lte', function() {
   eq(Z.lte(new Number(Infinity), new Number(-Infinity)), false);
   eq(Z.lte(new Number(-Infinity), new Number(Infinity)), true);
   eq(Z.lte(new Number(-Infinity), new Number(-Infinity)), true);
-  eq(Z.lte(new Number(NaN), new Number(Math.PI)), false);
+  eq(Z.lte(new Number(NaN), new Number(Math.PI)), true);
   eq(Z.lte(new Number(Math.PI), new Number(NaN)), false);
   eq(Z.lte(42, new Number(42)), false);
   eq(Z.lte(new Number(42), 42), false);