Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .mjs files in code coverage reports #27

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Apr 2, 2019

With --require esm in mocha.opts, it is possible to create test files that mix .js and .mjs files. Without this addition, nyc ignores the .mjs files when reporting code coverage.

@Avaq Avaq requested a review from davidchambers April 2, 2019 12:00
@Avaq Avaq force-pushed the avaq/cover-mjs branch from 3261985 to 700a673 Compare April 2, 2019 12:01
@Avaq Avaq changed the title Consider .mjs files for coverage instrumentation Include .mjs files in code coverage reports Apr 2, 2019
@Avaq Avaq force-pushed the avaq/cover-mjs branch from 700a673 to e4397d1 Compare April 2, 2019 12:01
@Avaq Avaq changed the title Include .mjs files in code coverage reports Add support for .mjs files in code coverage reports Apr 2, 2019
bin/test Show resolved Hide resolved
@Avaq Avaq force-pushed the avaq/cover-mjs branch from e4397d1 to ceb8d1e Compare April 2, 2019 15:29
Copy link
Member

@davidchambers davidchambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌳

@Avaq Avaq merged commit 12a7e9b into master Apr 2, 2019
@Avaq Avaq deleted the avaq/cover-mjs branch April 2, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants