-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'module-type' option determining how README is linted #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
force-pushed
the
avaq/doctest-module-type
branch
from
April 2, 2019 07:58
5d5803a
to
cd7c1c9
Compare
3 tasks
Avaq
force-pushed
the
avaq/doctest-module-type
branch
from
April 2, 2019 08:02
cd7c1c9
to
5507ab1
Compare
Avaq
force-pushed
the
avaq/doctest-module-type
branch
from
April 2, 2019 08:05
5507ab1
to
d4b7db6
Compare
Avaq
force-pushed
the
avaq/doctest-module-type
branch
from
April 2, 2019 08:07
d4b7db6
to
4f6d329
Compare
Avaq
force-pushed
the
avaq/doctest-module-type
branch
2 times, most recently
from
April 2, 2019 08:11
0ab1e50
to
20aa3d0
Compare
Avaq
force-pushed
the
avaq/doctest-module-type
branch
2 times, most recently
from
April 3, 2019 08:17
ae8bfe9
to
e2596fc
Compare
Avaq
force-pushed
the
avaq/doctest-module-type
branch
from
April 3, 2019 10:33
b191ccd
to
778ac24
Compare
Avaq
force-pushed
the
avaq/doctest-module-type
branch
from
April 3, 2019 13:25
c9787a4
to
f49f0f8
Compare
I left one last suggestion. Aside from that, everything looks very good to me. Let's squash and merge. :) |
Co-Authored-By: David Chambers <[email protected]>
Avaq
force-pushed
the
avaq/doctest-module-type
branch
from
April 4, 2019 11:21
5fe9c1b
to
39dcbe3
Compare
davidchambers
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
module-type
setting that users can add in their.config
. This option also ensures that code examples are treated as "modules" by the linter.