Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint-readme: respect ‘opening-delimiter’ and ‘closing-delimiter’ #24

Merged
merged 1 commit into from
Mar 21, 2019
Merged

lint-readme: respect ‘opening-delimiter’ and ‘closing-delimiter’ #24

merged 1 commit into from
Mar 21, 2019

Conversation

davidchambers
Copy link
Member

Closes #14

I have opened Avaq/permissionary#12 to demonstrate the efficacy of these changes.

@davidchambers davidchambers requested a review from Avaq March 19, 2019 16:42
Avaq
Avaq approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@Avaq Avaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The bash script is easier to read and the semicolon issue seems to be resolved.

@davidchambers davidchambers force-pushed the davidchambers/lint-readme branch from f47b6c3 to 962ddc0 Compare March 21, 2019 09:34
@davidchambers davidchambers merged commit b077d51 into master Mar 21, 2019
@davidchambers davidchambers deleted the davidchambers/lint-readme branch March 21, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avaq Avaq Avaq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidchambers @Avaq