rescue IO::EAGAINWaitReadable errors #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
Adds handling of IO::WaitReadable errors (such as IO::EAGAINWaitReadable) in the manner suggested by IO#read_nonblock documentation. The existing use of IO.select appears able to fail when only one of stdout or stderr is ready. Each file will now be retried if the read is not ready.
cjcolvar
force-pushed
the
WaitReadable
branch
from
798db4c to
f18dce7
Compare
cjcolvar
reviewed
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Adds handling of IO::WaitReadable errors (such as IO::EAGAINWaitReadable) in the manner suggested by IO#read_nonblock documentation. The existing use of IO.select appears able to fail when only one of stdout or stderr is ready. Each file will now be retried if the read is not ready.