Send tweet #1
Merged
Send tweet #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tweetText = messageRequest.content | ||
| } | ||
|
|
||
| var request = HTTPClientRequest(url: "https://api.twitter.com/2/tweets") |
There was a problem hiding this comment.
define the url as a const
| } | ||
| } | ||
|
|
||
| private func createHeader() -> String { |
There was a problem hiding this comment.
suggest "createAuthHeader", be as specific as possible
| request.body = .bytes(ByteBuffer(data: (try JSONSerialization.data(withJSONObject: jsonText)))) | ||
| let response = try await httpClient.execute(request, timeout: .seconds(30)) | ||
| try await httpClient.shutdown() | ||
| if response.headers["location"] == [] { |
There was a problem hiding this comment.
key this off response.status.code
| } | ||
| } | ||
|
|
||
| private func createHeader() -> String { |
There was a problem hiding this comment.
write a unit test for this function
There was a problem hiding this comment.
set this function to take function inputs rather than reading directly from the environment, that will make unit testing possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.