Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP links are not validated at creation #7

Closed
samuelroland opened this issue Mar 25, 2021 · 1 comment
Closed

HTTP links are not validated at creation #7

samuelroland opened this issue Mar 25, 2021 · 1 comment
Assignees
@samuelroland
Labels
bug Something isn't working validation Concern the data validation

Comments

@samuelroland
Copy link
Owner

The extension should check with a Regex that the link entered is valid and not "blabla hey" or another invalid link.
@samuelroland samuelroland added the bug Something isn't working label Mar 25, 2021
@samuelroland samuelroland self-assigned this Mar 25, 2021
@samuelroland samuelroland added the validation Concern the data validation label Mar 25, 2021
@samuelroland samuelroland mentioned this issue Mar 25, 2021
Closed
samuelroland added a commit that referenced this issue Mar 27, 2021
@samuelroland
close the current message when link validation is successful #7
0d48f37
@samuelroland
Copy link
Owner Author

samuelroland commented Mar 28, 2021 •
edited
Loading

Actually I didn't read very well the Regex and I introduce a bug. Link like rts.ch/home are not valid... (Only domain name is accepted). I will fix it soon.

LINK_REGEX:  "^(((https?:\\/\\/)|(www\\.)|())((([A-Z\\d_-]+\\.)+)([A-Z\\d_-]+)|(localhost))((:\\d{2,4})?))$"

@samuelroland samuelroland reopened this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelroland samuelroland

Labels
bug Something isn't working validation Concern the data validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samuelroland