Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse focus #1

Closed
EGiorgisCPNV opened this issue Mar 17, 2021 · 4 comments
Closed

Mouse focus #1

EGiorgisCPNV opened this issue Mar 17, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@EGiorgisCPNV
Copy link

EGiorgisCPNV commented Mar 17, 2021

Impossible to finalize the creation of a link if you check or uncheck the checkbox with a mouse click for the question of a local or remote rest, because the focus does not work anymore

@samuelroland samuelroland self-assigned this Mar 17, 2021
@samuelroland samuelroland added the bug Something isn't working label Mar 17, 2021
@samuelroland
Copy link
Owner

Hey. Thanks for this bug report. In my manual tests, I never used the mouse to check/uncheck the checkbox. I tried to reproduce the bug and I saw that the focus on the checkbox is kept if the mouse doesn't click in other places (test with Firefox 86.0.1 on Windows), BUT that on MacOS Catalina with same version of Firefox, the focus is left in all cases when using the mouse... This difference between MacOS and Windows surprised me...

I will try to find an easy solution to fix this before the v1.0.

@samuelroland
Copy link
Owner

Hey,
I have reflected a bit to this bug. The quick fix is to focus explicitly the checkbox on mouse click, to avoid lose of focus. The long fix is to enable keyup event listen on the whole extension (to be sure that the Enter will always be possible to hit, even if the mouse click outside of the input), but this other solution imply that the other fields have to be disabled (else the extension is not able to know which action is wanted (link or category creation)).

I will implement the quick fix for v1.0 and we will see later if another strategy is needed.

samuelroland added a commit that referenced this issue Mar 25, 2021
to be sure to not lose the focus on mouse click, at link creation.
@samuelroland
Copy link
Owner

image

It's fixed ! Here eb638a9. I tested it on MacOS with mouse click and the focus is kept.

@samuelroland
Copy link
Owner

Will be naturally available for v1.0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants