Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix badge for CI #323

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix badge for CI #323

merged 2 commits into from
Jan 10, 2025

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 3, 2025

image

@samuelcolvin
Copy link
Owner

The link definitely shouldn't be to the yaml file, but to the list of recent runs.

@ofek
Copy link
Contributor Author

ofek commented Jan 3, 2025

It is, have you tried it?

@ofek
Copy link
Contributor Author

ofek commented Jan 4, 2025

Is there something else you wanted it to point to instead? I'm confused.

samuelcolvin
samuelcolvin reviewed Jan 10, 2025
View reviewed changes
Copy link
Owner

@samuelcolvin samuelcolvin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the link is to the yaml file, it should be to the workflow IMHO.

Okay I see the link referencing the yml files shows the list of actions.

README.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@samuelcolvin samuelcolvin merged commit 8d89bde into samuelcolvin:main Jan 10, 2025
47 checks passed
@ofek ofek deleted the patch-1 branch January 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @samuelcolvin