Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsm push (all-scripts invocation) does not follow symbolic links #155

Closed
Tracked by #154
danswann opened this issue Apr 17, 2024 · 5 comments
Closed
Tracked by #154

hsm push (all-scripts invocation) does not follow symbolic links #155

danswann opened this issue Apr 17, 2024 · 5 comments

Comments

@danswann
Copy link
Contributor

If you have a script symlinked to a different location, you can push it on its own explicitly, i.e.:

hsm push src myuser.symlinked_script

but if you run the global push

hsm push

any symlinked scripts are not discovered.
@danswann
Copy link
Contributor Author

hsm push myuser.* also fails, while hsm push *.symlinked_script succeeds.

@samualtnorman
Copy link
Owner

ty for reporting

@samualtnorman samualtnorman mentioned this issue Apr 16, 2024
Closed
8 tasks
@samualtnorman
Copy link
Owner

samualtnorman commented Apr 17, 2024 •
edited
Loading

please can you try pnpm add [email protected].
I've updated hsm push (and only hsm push atm)

@danswann
Copy link
Contributor Author

Fixed in all mentioned cases for hsm push.

@samualtnorman
Copy link
Owner

nice! I'll apply the same changes else where and then close this issue

samualtnorman added a commit that referenced this issue Apr 17, 2024
@samualtnorman
switch to @samual/lib/readDirectoryWithStats from `fs.promises.read…
003b022 
…dir()`

this means symlinks are now followed #155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danswann @samualtnorman