Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace "UNKNOWN"s with something better #151

Closed
3 tasks done
Tracked by #154
samualtnorman opened this issue Mar 29, 2024 · 2 comments
Closed
3 tasks done
Tracked by #154

replace "UNKNOWN"s with something better #151

samualtnorman opened this issue Mar 29, 2024 · 2 comments

Comments

@samualtnorman
Copy link
Owner

samualtnorman commented Mar 29, 2024 •
edited
Loading

  • _SCRIPT_USER
  • _SCRIPT_NAME
  • _FULL_SCRIPT_NAME
@samualtnorman samualtnorman mentioned this issue Apr 16, 2024
Closed
8 tasks
samualtnorman added a commit that referenced this issue Apr 25, 2024
@samualtnorman
replace _SCRIPT_USER with variable to `context.this_script.split(".…
b720a68 
…")[0]` when not known instead of replacing with `"UNKNOWN"`

part way to #151
@samualtnorman samualtnorman changed the title instead of getting "UNKNOWN" you should be able to pass what they should be as an option replace "UNKNOWN"s with something better Apr 25, 2024
@samualtnorman
Copy link
Owner Author

I've done the hard one, the other 2 should be a lot easier

samualtnorman added a commit that referenced this issue Apr 26, 2024
@samualtnorman
mandate scriptName option to processScript() and transform()
b80922d 
turns out there isn't actually anywhere where my code isn't passing the `scriptName` so this change is only an API change
to make this change there was a slight refactor of making all the option object types `LaxPartials` themselves rather than it being the responsibility of the user of the type to `Partial`ify it
as a part of this change, `preprocess()` has gone from accepting a regular `Partial<>` options object to a `LaxPartial<>` options object
this is all for progress for replace `"UNKNOWN"`s with something better #151
@samualtnorman
Copy link
Owner Author

samualtnorman commented Apr 26, 2024 •
edited
Loading

turns out _FULL_SCRIPT_NAME has a bug where

export default () => _FULL_SCRIPT_NAME

can turn into

function(){return"undefined.foo"}

I'm gonna go ahead and fix this as a part of this issue

samualtnorman added a commit that referenced this issue Apr 26, 2024
@samualtnorman
fix _FULL_SCRIPT_NAME turning into "undefined.foo"
c2f3057 
this is the last step for replace `"UNKNOWN"`s with something better #151
this fix doesn't actually replace `"UNKNOWN"`, there was a bug that meant there was no `"UNKNOWN"` where there probably should have been one but I've skipped the middle step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samualtnorman