Adjust GitHub actions windows build package list #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the mingw-w64-x86_64 flavour of all packages. Add curl, so hfile_libcurl etc. build. Remove the mingw git package as git for windows is already present. Add the location of git for windows to $PATH (note this must be at the end, else the wrong shell gets picked up when running tests leading to backslash conversion issues). Switch the badge on README.md from AppVeyor to GitHub.
|
Adding curl is important, thanks. I don't get the git thing though. Adding to path only changes builds, not clones, and the only bit of the build process using git is probably a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the mingw-w64-x86_64 flavour of all packages. Add curl, so hfile_libcurl etc. build. Remove the mingw git package as git for windows is already present. Add the location of git for windows to
$PATH(note this must be at the end, else the wrong shell gets picked up when running tests leading to backslash conversion issues).Switch badge on README.md from AppVeyor to GitHub.