Make BAM zero-length intervals work like CRAM #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a BED file with: chr1 1000 1000 Worked with CRAM multi-region iterator but not with BAM. This change makes them work the same. Fixes #2060.
|
Ironically I just hit this very same bug! (Thanks for the fix.) The test data in samtools/samtools#2063 demonstrates this as it includes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a BED file with:
chr1 1000 1000
samtools view -M -L intervals.bed $infileworked with CRAM multi-region iterator but not with BAM. This change makes them work the same. Fixes samtools/samtools#2060.NB Even though BED file format (spec) has a 0-based, half-open coordinate system, having the same beginning and end coordinate is valid.