Fix nested partial indentation and custom spec tests #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
agentgt
commented
Nov 21, 2023
| boolean last; | ||
| if (nseg instanceof BlockSegment){ | ||
| BlockSegment bs = (BlockSegment) nseg; | ||
| last = bs.isStandaloneStart(); |
There was a problem hiding this comment.
Whoops this should be inverted.
agentgt
commented
Nov 21, 2023
| } | ||
| //segs[ii-1] = prev.trimTrailBlank(); |
There was a problem hiding this comment.
Meant to remove this comment and add a new one discussing how the previous segment should not be trimmed.
|
Feel free to send a new PR with the tweaks. |
|
I will. I'm working on inheritance but I will put a separate commit for the tweak as well as some testing since a test should have found that 😄 . Inheritance should hopefully not be too hard. Based on experience the hardest part of Mustache is the whitespace handling and now that I think that is mostly fixed it should be smooth sailing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samskivert
I fixed the previous nested indentation.
I'm sorry it took me longer than I promised.
I added custom spec tests in
src/main/resources/custom/spec.BTW this time I tried to sick more with the projects formatting.
What I plan on doing is eventually putting in the Eclipse Maven formatter plugin which I have used with great success in the past: https://code.revelc.net/formatter-maven-plugin/
(no it doesn't require Eclipse its just that Eclipse headless formatter is the most powerful one where as the others are opinionated).