oauthproxy: forward Host header explicitly #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy should send the requested Host header up so that CheckOrigin passes correctly on the upstream target's side. Also see: //github.com/koding/websocketproxy/issues/9
berfarah
approved these changes
Oct 29, 2018
| @@ -132,6 +132,9 @@ func setProxyUpstreamHostHeader(proxy *ReverseProxy, target *url.URL) { | |||
| req.URL.Opaque = req.RequestURI | |||
| req.URL.RawQuery = "" | |||
| } | |||
| proxy.wsProxy.Director = func(req *http.Request, out http.Header) { | |||
There was a problem hiding this comment.
Is there any x-forwarded-for that should happen as well? Or is that already handled?
There was a problem hiding this comment.
it's handled by the proxy itself. I think this should also be handled by the proxy by default, mentioned here: koding/websocketproxy#9 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy should send the requested Host header up so that CheckOrigin passes correctly on the upstream target's side.
Also see: koding/websocketproxy#9. My belief from reading the issue is that the proxy should handle this but does not.