Code

Refactoring, fixes and improvements#5

Code

Merged

samsamfire merged 46 commits intomainsamsamfire/gocanopen:mainfrom devsamsamfire/gocanopen:devCopy head branch name to clipboardMay 1, 2024

+7,603-6,053

Commits

Commits on Jan 19, 2024

• Reworking HTTP gateway

  Show description for 3e5f611
  samsamfire

  committed
  3e5f611

  Copy full SHA for 3e5f611

Commits on Jan 31, 2024

• Moving HTTP gateway to a seperate package

  Show description for 535f7c6
  samsamfire

  committed
  535f7c6

  Copy full SHA for 535f7c6

Commits on Feb 5, 2024

• Starting to have a pretty good architecture, easy to add new routes

  Show description for f00d6ab
  samsamfire

  committed
  f00d6ab

  Copy full SHA for f00d6ab

Commits on Feb 6, 2024

• Fixed broken http example

  samsamfire

  committed
  ae6f4df

  Copy full SHA for ae6f4df

Commits on Feb 8, 2024

• Added TIME configurator with tests

  Show description for 26dc03a
  samsamfire

  committed
  26dc03a

  Copy full SHA for 26dc03a

Commits on Mar 14, 2024

• Seperating CAN driver implementation into a seperate package

  samsamfire

  committed
  3822336

  Copy full SHA for 3822336

Commits on Mar 16, 2024

• Major refactor :

  Show description for fe52200
  samsamfire

  committed
  fe52200

  Copy full SHA for fe52200

Commits on Mar 17, 2024

• Reenabled all the tests, and passing

  Show description for 51bd379
  samsamfire

  committed
  51bd379

  Copy full SHA for 51bd379

Commits on Mar 18, 2024

• Working on linting improvements

  samsamfire

  committed
  7fb356f

  Copy full SHA for 7fb356f

• Fixes reported by gocritic : essentially some simplifications, and added a space in front of beginning of all comments

  Show description for b4991b0
  samsamfire

  committed
  b4991b0

  Copy full SHA for b4991b0

• Replacing long if-else-if with switch statements, less indentation

  samsamfire

  committed
  7911c17

  Copy full SHA for 7911c17

Commits on Mar 22, 2024

• Embed sdoClient in config objects

  Show description for cb974c1
  samsamfire

  committed
  cb974c1

  Copy full SHA for cb974c1

• Docs are not capitalized anymore.

  Show description for c9d7f0b
  samsamfire

  committed
  c9d7f0b

  Copy full SHA for c9d7f0b

Commits on Mar 23, 2024

• Added test for set internal time and moved time origin as a global var

  samsamfire

  committed
  461dc63

  Copy full SHA for 461dc63

• TIME :

  Show description for 967992f
  samsamfire

  committed
  967992f

  Copy full SHA for 967992f

• Fixed : TIME was checking frame length instead of frame.DLC, meaning consumers never processed the timestamp

  Show description for ed84876
  samsamfire

  committed
  ed84876

  Copy full SHA for ed84876

• Added : Read software information objects, will probably refactor

  Show description for 7c0f125
  samsamfire

  committed
  7c0f125

  Copy full SHA for 7c0f125

• Fixed : Logic error introduced in time call subscribe when isConsumer is accessed, even if already the case

  Show description for 51f8086
  samsamfire

  committed
  51f8086

  Copy full SHA for 51f8086

• Fixed : stop ever growing callbacks when subscribing by checking if has already been added

  samsamfire

  committed
  0128b4e

  Copy full SHA for 0128b4e

• Changed : updated od.md documentation

  Show description for dad1c62
  samsamfire

  committed
  dad1c62

  Copy full SHA for dad1c62

• Changed : tiny bit of cleaning

  Show description for 0860623
  samsamfire

  committed
  0860623

  Copy full SHA for 0860623

• Fixed : added inhibit time entry to addPDO, which was causing NewRemoteNode to error

  samsamfire

  committed
  141e072

  Copy full SHA for 141e072

• Fixed : race conditions on TIME object

  samsamfire

  committed
  4f715b4

  Copy full SHA for 4f715b4

• Fixed : getting rid of race conditions with -race tool

  samsamfire

  committed
  f65ebca

  Copy full SHA for f65ebca

• Fix : add locking for SYNC object

  samsamfire

  committed
  f7f14c4

  Copy full SHA for f7f14c4

• Fix : error in Subscribe callback in for look, func parameter had same name as var, which caused errors

  samsamfire

  committed
  a94b7d5

  Copy full SHA for a94b7d5

Commits on Mar 24, 2024

• Fixed : Deadlock for sdo abort

  samsamfire

  committed
  03ef546

  Copy full SHA for 03ef546

• Fixed : Deadlock in SYNC send, when receiving own messages. We need to release lock before sending

  samsamfire

  committed
  547cad6

  Copy full SHA for 547cad6

• Fixed : race condition on SYNC extensions, because the []byte slice containing entries 1006 & 1007 are directly referenced in SYNC object. So add locking also

  Show description for 971c4ab
  samsamfire

  committed
  971c4ab

  Copy full SHA for 971c4ab

• Changed : PDOCommon is now a pointer, for project consistency and also to avoid sync.Mutex copies

  samsamfire

  committed
  31ffaa6

  Copy full SHA for 31ffaa6

• Fixed / Changed : Variable objects now have a mutex to prevent concurrent access between go routines. Especially true for PDOs for example, which update OD without SDO.

  Show description for 95656c3
  samsamfire

  committed
  95656c3

  Copy full SHA for 95656c3

Commits on Mar 29, 2024

• Changed : moved CAN interface to top level (in canopen module)

  Show description for 0863cfd
  samsamfire

  committed
  0863cfd

  Copy full SHA for 0863cfd

• Fixed : fixed python tests, should run properly

  samsamfire

  committed
  c21971f

  Copy full SHA for c21971f

• Changed : embed Stream in Streamer

  samsamfire

  committed
  82acec0

  Copy full SHA for 82acec0

Commits on Apr 1, 2024

• Changed : AddRemoteNode does not initialize PDOs straight away, StartPDOs needs to be called.

  Show description for 0bf41f0
  samsamfire

  committed
  0bf41f0

  Copy full SHA for 0bf41f0

• Refactored : Moved node specific tests to node_test (removed network_sdo)

  Show description for afa1461
  samsamfire

  committed
  afa1461

  Copy full SHA for afa1461

• Refactored : moved read/write node to seperate sdo file

  samsamfire

  committed
  9b406e6

  Copy full SHA for 9b406e6

Commits on Apr 2, 2024

• Feature : Add ReadIdentity and ReadManufacturerInformation, added tests

  Show description for dcc708b
  samsamfire

  committed
  dcc708b

  Copy full SHA for dcc708b

• Changed : RemoveNode returns an error in case no id was found

  Show description for 7a3ea85
  samsamfire

  committed
  7a3ea85

  Copy full SHA for 7a3ea85

Commits on Apr 11, 2024

• Changed : renamed Encode in od to EncodeFromString and added EncodeFromGeneric to encode from any type

  samsamfire

  committed
  8fc779c

  Copy full SHA for 8fc779c

• Changed/Feature : changes for implementing io.Reader and io.Writer interface for sdo client, not working yet

  samsamfire

  committed
  2e45054

  Copy full SHA for 2e45054

Commits on Apr 15, 2024

• Fixed : wrong order inside downloadMain of sdo client

  Show description for cd7eeff
  samsamfire

  committed
  cd7eeff

  Copy full SHA for cd7eeff

Commits on Apr 27, 2024

• Added : profiling in canopen_test

  Show description for 844be19
  samsamfire

  committed
  844be19

  Copy full SHA for 844be19

• Changed : piling up defers in HB consumer seems to increase CPU usage. Don't defer in for loop.

  samsamfire

  committed
  84d9a72

  Copy full SHA for 84d9a72

Commits on Apr 28, 2024

• Refactored : changed kebab_case to camelCase for NMT related constants

  Show description for ba70a30
  samsamfire

  committed
  ba70a30

  Copy full SHA for ba70a30

• Refactored : continued refactoring of kebab_case constants

  samsamfire

  committed
  4936852

  Copy full SHA for 4936852