Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Estimated Number of Keys Function #1817

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

alexanderkiel
Copy link
Member

We need this functionality for all key-value instead of only for RocksDB because we will use it in the CQL expression cache.

Needed in: #1051

We need this functionality for all key-value instead of only for
RocksDB because we will use it in the CQL expression cache.

Needed in: #1051
@alexanderkiel alexanderkiel self-assigned this Jun 24, 2024
@alexanderkiel alexanderkiel added this to the v0.28.0 milestone Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (4497165) to head (994694d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1817   +/-   ##
========================================
  Coverage    96.19%   96.19%           
========================================
  Files          271      271           
  Lines        17342    17350    +8     
  Branches       347      347           
========================================
+ Hits         16682    16690    +8     
  Misses         313      313           
  Partials       347      347           
Files Coverage Δ
modules/admin-api/src/blaze/admin_api.clj 98.03% <100.00%> (ø)
modules/kv/src/blaze/db/kv.clj 100.00% <100.00%> (ø)
modules/kv/src/blaze/db/kv/mem.clj 100.00% <100.00%> (ø)
modules/kv/src/blaze/db/kv/protocols.clj 100.00% <ø> (ø)
modules/rocksdb/src/blaze/db/kv/rocksdb.clj 99.36% <100.00%> (+<0.01%) ⬆️

@alexanderkiel alexanderkiel merged commit 8a4b1a9 into develop Jun 24, 2024
162 checks passed
@alexanderkiel alexanderkiel deleted the estimate-num-keys branch June 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant