Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML Output for Resources with Control Chars #1553

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

alexanderkiel
Copy link
Member

If resources contain control characters like \u001e (record separator) in strings or other string like primitive type values, the XML generator can't output them. Because the resulting exception is not handled, the output hangs and will never finish.

Closes: #1552

If resources contain control characters like \u001e (record separator)
in strings or other string like primitive type values, the XML generator
can't output them. Because the resulting exception is not handled, the
output hangs and will never finish.

Closes: #1552
@alexanderkiel alexanderkiel self-assigned this Mar 14, 2024
@alexanderkiel alexanderkiel added this to the v0.25 milestone Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (a820081) to head (8a81f5a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1553   +/-   ##
========================================
  Coverage    95.89%   95.90%           
========================================
  Files          246      246           
  Lines        15903    15908    +5     
  Branches       332      331    -1     
========================================
+ Hits         15250    15256    +6     
  Misses         321      321           
+ Partials       332      331    -1     
Files Coverage Δ
...odules/fhir-structure/src/blaze/fhir/spec/impl.clj 95.90% <100.00%> (ø)
...odules/fhir-structure/src/blaze/fhir/spec/type.clj 84.38% <100.00%> (+0.18%) ⬆️
...fhir-structure/src/blaze/fhir/spec/type/system.clj 97.72% <100.00%> (ø)
.../rest-api/src/blaze/rest_api/middleware/output.clj 100.00% <100.00%> (ø)

@alexanderkiel alexanderkiel merged commit 39d577d into develop Mar 14, 2024
136 checks passed
@alexanderkiel alexanderkiel deleted the fix-handling-control-chars-xml branch March 14, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant