Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain Referential Integrity while Deleting Resources #1425

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented Jan 22, 2024

Closes: #543

@alexanderkiel alexanderkiel changed the title Referential integrity delete Maintain Referential Integrity while Deleting Resources Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e422887) 95.84% compared to head (a63a013) 95.85%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1425   +/-   ##
========================================
  Coverage    95.84%   95.85%           
========================================
  Files          245      245           
  Lines        15839    15874   +35     
  Branches       335      335           
========================================
+ Hits         15181    15216   +35     
  Misses         323      323           
  Partials       335      335           
Files Coverage Δ
modules/db/src/blaze/db/api.clj 94.78% <100.00%> (+0.04%) ⬆️
modules/db/src/blaze/db/impl/batch_db.clj 94.96% <100.00%> (+0.43%) ⬆️
modules/db/src/blaze/db/impl/db.clj 97.36% <100.00%> (+0.07%) ⬆️
...les/db/src/blaze/db/impl/index/resource_handle.clj 95.08% <100.00%> (+0.25%) ⬆️
modules/db/src/blaze/db/node/transaction.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/node/tx_indexer/verify.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/search_param_registry.clj 97.27% <100.00%> (ø)
...dules/rest-api/src/blaze/rest_api/capabilities.clj 97.56% <100.00%> (ø)

@alexanderkiel alexanderkiel added the bug Something isn't working label Jan 22, 2024
@alexanderkiel alexanderkiel added this to the v0.24.0 milestone Jan 22, 2024
Copy link
Member Author

@alexanderkiel alexanderkiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fill out the documentation on the delete transaction command in docs/implementation/database.md. Also please write a section on the delete interaction in docs/api.md were we say that referential integrity is checked depending on ENFORCE_REFERENTIAL_INTEGRITY since version 0.24.0.

modules/db/test/blaze/db/node/tx_indexer/verify_test.clj Outdated Show resolved Hide resolved
modules/db/test/blaze/db/node/tx_indexer/verify_test.clj Outdated Show resolved Hide resolved
modules/db/test/blaze/db/api_test.clj Outdated Show resolved Hide resolved
modules/db/test/blaze/db/api_test.clj Outdated Show resolved Hide resolved
modules/db/test/blaze/db/api_test.clj Outdated Show resolved Hide resolved
modules/db/test/blaze/db/api_test.clj Outdated Show resolved Hide resolved
@alexanderkiel alexanderkiel modified the milestones: v0.24.0, v0.25 Feb 5, 2024
@sonatsuer sonatsuer force-pushed the feature/543-referential-integrity-delete branch 3 times, most recently from ea15b69 to 9bd2840 Compare February 14, 2024 12:27
@alexanderkiel alexanderkiel force-pushed the feature/543-referential-integrity-delete branch from 55f3cda to 0f297d8 Compare February 16, 2024 10:59
@alexanderkiel alexanderkiel force-pushed the feature/543-referential-integrity-delete branch from 0f297d8 to a63a013 Compare February 16, 2024 12:04
@alexanderkiel alexanderkiel merged commit 63fb998 into develop Feb 16, 2024
135 checks passed
@alexanderkiel alexanderkiel deleted the feature/543-referential-integrity-delete branch February 16, 2024 12:22
@alexanderkiel alexanderkiel self-assigned this Feb 26, 2024
@alexanderkiel alexanderkiel added enhancement New feature or request and removed bug Something isn't working labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:db
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants