Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Concurrent Use of KV Iterators #1262

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented Nov 9, 2023

The cost of opening an iterator doesn't impact the query performance in a significant way. Especially if we have a CQL Cache through #1051 the performance impact would be negligible.

I didn't make this as bug because the problem was only exposed by #1244 which was not released before.

Closes: #1217

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1262 (ae85e62) into develop (a916cf4) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 97.80%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1262      +/-   ##
===========================================
- Coverage    95.26%   95.25%   -0.01%     
===========================================
  Files          242      242              
  Lines        15342    15394      +52     
  Branches       355      357       +2     
===========================================
+ Hits         14616    14664      +48     
- Misses         371      373       +2     
- Partials       355      357       +2     
Files Coverage Δ
modules/db/src/blaze/db/impl/db.clj 97.18% <100.00%> (ø)
modules/db/src/blaze/db/impl/index.clj 100.00% <100.00%> (ø)
...b/src/blaze/db/impl/index/compartment/resource.clj 98.18% <100.00%> (+0.10%) ⬆️
...ules/db/src/blaze/db/impl/index/resource_as_of.clj 98.43% <100.00%> (+0.18%) ⬆️
...laze/db/impl/index/resource_search_param_value.clj 100.00% <100.00%> (ø)
...odules/db/src/blaze/db/impl/index/system_as_of.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/impl/index/type_as_of.clj 100.00% <100.00%> (ø)
modules/db/src/blaze/db/impl/search_param.clj 100.00% <ø> (ø)
...ules/db/src/blaze/db/impl/search_param/chained.clj 100.00% <100.00%> (ø)
.../db/impl/search_param/composite/token_quantity.clj 97.14% <100.00%> (ø)
... and 10 more

@alexanderkiel alexanderkiel force-pushed the fix/concurrent-db-iterator-usage branch from a839ea3 to b1b60da Compare November 9, 2023 14:43
The cost of opening an iterator doesn't impact the query performance in
a significant way. Especially if we have a CQL Cache through #1051 the
performance impact would be negligible.

Closes: #1217
@alexanderkiel alexanderkiel force-pushed the fix/concurrent-db-iterator-usage branch from b1b60da to ae85e62 Compare November 9, 2023 16:06
@alexanderkiel alexanderkiel self-assigned this Nov 9, 2023
@alexanderkiel alexanderkiel added bug Something isn't working module:db and removed bug Something isn't working labels Nov 9, 2023
@alexanderkiel alexanderkiel changed the title [WIP] Fix Concurrent Use of KV Iterators Fix Concurrent Use of KV Iterators Nov 9, 2023
@alexanderkiel alexanderkiel added this to the v0.23.0 milestone Nov 9, 2023
@alexanderkiel alexanderkiel merged commit 2625bf3 into develop Nov 9, 2023
@alexanderkiel alexanderkiel deleted the fix/concurrent-db-iterator-usage branch November 9, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant