Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check command #11

Closed
wants to merge 2 commits into from
Closed

Conversation

norbinsh
Copy link
Contributor

@norbinsh norbinsh commented Oct 4, 2020

Addresses #6.

Please let me know if any changes required.

@norbinsh
Copy link
Contributor Author

norbinsh commented Oct 4, 2020

On a side note, it seems that digitalocean changed their "hacktoberfest" rules and now a repository is only eligible if it has the "hacktoberfest" topic added to their repository (in the "about" section). would be great support if you could add it before merging (I may want/need to re-create the PR if tha'ts OK with you).
see here.

@samit22
Copy link
Owner

samit22 commented Oct 5, 2020

Can you also update readme with thew command?

while using regular expression pattern matching.`,
Args: cobra.MinimumNArgs(1),
Run: func(cmd *cobra.Command, args []string) {
uuidPattern := "^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to a function so that writing unit test is possible?

Also, how about supporting multiple UUIDs in the argument? And giving responses to each as true false? I leave that up to you.

@norbinsh
Copy link
Contributor Author

norbinsh commented Oct 5, 2020

hi @samit22. thank you for the notes, agreed.
i am will create a new PR (for the hacktoberfest part mainly) in just a few.
closing this one.

@norbinsh norbinsh closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants