Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to generate empty/nil UUID #10

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

slomek
Copy link
Contributor

@slomek slomek commented Oct 3, 2020

Fixes #9.

Adding a testable example may be controversial so feel free to reject this part. I just assumed that testing it in any other way would not make much sense, since you chose to use fmt.Println in other places to write to the console directly, the only way I can think of testing this would be introducing yet another abstractio level and generate empty UUID there (and test that function). Seemed like an overkill, but you're the boss here 😉

Copy link
Owner

@samit22 samit22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm also looking for a better way to test, maybe an integration one.

@samit22 samit22 merged commit 22d9644 into samit22:main Oct 3, 2020
@slomek
Copy link
Contributor Author

slomek commented Oct 3, 2020

Thank you @samit22! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command for generate Nil/Empty UUID
2 participants