-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetStandard 2.0 support #35
Comments
Upgrade dependencies
What are the benefits of targeting a higher version? |
That was my thought too. The current library targeting NetStandard 1.5 is usable with both .NET Core 1.0 and 2.0 (and .NET Framework 4.6.1+). Is there a benefit to having a version targeting NetStandard 2.0 (when it isn't using any of the additional APIs made available in that version)? |
Netstandard2.0 resolves a decent amount of referencing netstandard issues from my understanding. |
Build process: dotnet restore won't pull older versions during the build |
@Shatl can you clarify what you mean? I'm not sure what the problem is. |
@samcook When building on NetStandard 2 docker image (aspnetcore-build:2) dotnet restore has to pull NetStandard dependencies which increases build time |
Up this. We have a failed build after upgrade to 4.7.2 due to assembly conflicts. |
I've pushed out a prerelease package (version 2.1.0-pre2) which now includes a NetStandard 2.0 target, and tweaks the nuget dependencies a little. Any feedback on whether this solves the referencing issues people have mentioned is appreciated. |
Thanks! It works, at least for us:)
вс, 10 июн. 2018 г., 0:05 Sam Cook <[email protected]>:
… I've pushed out a prerelease package (version 2.1.0-pre2) which now
includes a NetStandard 2.0 target, and tweaks the nuget dependencies a
little.
Any feedback on whether this solves the referencing issues people have
mentioned is appreciated.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKtImbmgwMbJFYDxAsMoqMHF6Twsqlj0ks5t7DihgaJpZM4TB6KY>
.
|
Works fine. Thanks! |
@samcook Could you publish release package ? |
Done (finally!) |
Please add NetStandard 2.0 binaries to NuGet
The text was updated successfully, but these errors were encountered: