sit.cephfs: Add proxy enbaled shares with vfs_ceph_new (mgr)
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
changed the title
vfs_ceph_new (mgr)
It is not a big deal for us to fit the method name within the current
limit for share_id based on the following regular expression from smb
mgr module:
^[a-zA-Z0-9]($|[a-zA-Z0-9-]{,16}[a-zA-Z0-9]$)
Otherwise share id 'share-vfs-new-proxy' constituted goes beyond the
limit resulting in failure to create share using mgr variant.
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
anoopcs9
force-pushed
the
add-cephfs-proxy-mgr
branch
2 times, most recently
from
b6f2005 to
2f69fc4
Compare
xhernandez
approved these changes
Feb 28, 2025
phlogistonjohn
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ceph/ceph#59740 merged ceph smb manager module is capable of creating shares with
ceph_new:proxymodule option set to "yes". Thus an additional share with proxy support is created for mgr variant.