ctdb: add ctdb-monitor-nodes command #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the help text for `--write-nodes`. The previous help text was incorrect copy-paste. Signed-off-by: John Mulligan <[email protected]>
Move the limited-retries-on-error logic to a class that can be reused later. Signed-off-by: John Mulligan <[email protected]>
Rename a function to manage_cluster_meta_updates to better match what it does. A future change will want to use the word "monitor" for something else and it would be confusing to continue calling this a "monitor" function vs "manage -- and this function is the more active "participant" of the two. Signed-off-by: John Mulligan <[email protected]>
Make the doc comment on ctdb_manage_nodes more accurate. Signed-off-by: John Mulligan <[email protected]>
Split out some logic from the cluster_meta_to_nodes function into separate functions for current & later reuse. Signed-off-by: John Mulligan <[email protected]>
|
Note: this function is "co-evolving" with the ceph branch I have adding experimental ctdb support to smb-on-ceph. I expect this function to keep evolving a bit as the ceph support is improved and refined as well. I'm also hoping that eventually we can move away from writing the nodes file and use a nodes hook script, but that depends on changes in ctdb. That's one reason that this is a whole new subcommand. The other is that when I looked into combining this with the existing manage node updaetes function it was clear that the features needed there (the k8s samba-operator) is diverging a bit from the feature set we want on ceph, so it seems safer and less regression prone to just make a different function altogether. |
synarete
reviewed
Jul 16, 2024
Signed-off-by: John Mulligan <[email protected]>
Add the monitor_cluster_meta_changes to the ctdb module. This function monitors the cluster meta and can reflect those changes into the ctdb nodes file and/or call reload nodes. Unlike the previous manage_cluster_meta_updates the sambacc process is not an active participant in the management of the cluster meta rather we assume some outside entity is updating the metadata with the desired state of the cluster correctly. monitor_cluster_meta_changes exists to translate that state into something ctdb can use. Signed-off-by: John Mulligan <[email protected]>
Add a `ctdb-monitor-nodes` command - this command will monitor the cluster meta and update the containers/ctdb when/if it changes. The `--write-nodes` parameter is used to instruct the command to write the ctdb nodes file on changes. The `--reload` option is used to control what "nodes" issue `ctdb reloadnodes` commands: leader (only the cluster leader), all (all nodes that see the cluster meta change), and never (never issue reloadnodes commands). Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-ctdb-mon
branch
from
b625784 to
c0154c0
Compare
|
@anoopcs9 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
ctdb-monitor-nodescommand - this command will monitor thecluster meta and update the containers/ctdb when/if it changes.
The
--write-nodesparameter is used to instruct the command towrite the ctdb nodes file on changes. The
--reloadoption is used tocontrol what "nodes" issue
ctdb reloadnodescommands: leader (only thecluster leader), all (all nodes that see the cluster meta change), and never
(never issue reloadnodes commands).