Do not generate workflow timeout task if workflow is closed (temporal…

…io#4135)
samanbarghi · May 2, 2023 · b488c47 · b488c47
1 parent b5afc76
commit b488c47
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/service/history/workflow/task_generator.go b/service/history/workflow/task_generator.go
@@ -141,13 +141,14 @@ func (r *TaskGeneratorImpl) GenerateWorkflowStartTasks(
 		return nil
 	}
 
-	r.mutableState.AddTasks(&tasks.WorkflowTimeoutTask{
-		// TaskID is set by shard
-		WorkflowKey:         r.mutableState.GetWorkflowKey(),
-		VisibilityTimestamp: workflowRunExpirationTime,
-		Version:             startVersion,
-	})
-
+	if r.mutableState.IsWorkflowExecutionRunning() {
+		r.mutableState.AddTasks(&tasks.WorkflowTimeoutTask{
+			// TaskID is set by shard
+			WorkflowKey:         r.mutableState.GetWorkflowKey(),
+			VisibilityTimestamp: workflowRunExpirationTime,
+			Version:             startVersion,
+		})
+	}
 	return nil
 }