Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix for assume role when used salt-cloud to create aws ec2 #64481

Conversation

tryfunc
Copy link
Contributor

@tryfunc tryfunc commented Jun 14, 2023

What does this PR do?

Fixes assuming role when used salt-cloud to create aws ec2.

What issues does this PR fix or reference?

Fixes: #52501

Previous Behavior

The repeated function call did not call the function assumed_creds, because in the case of a valid __Expiration__ - active creds were returned (return __AccessKeyId__, __SecretAccessKey__, __Token__) and the function execution was interrupted.

New Behavior

The expression has been changed.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@tryfunc tryfunc requested a review from a team as a code owner June 14, 2023 14:57
@tryfunc tryfunc requested review from whytewolf and removed request for a team June 14, 2023 14:57
@welcome
Copy link

welcome bot commented Jun 14, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix for assume role when used salt-cloud to create aws ec2 [3006.x] Fix for assume role when used salt-cloud to create aws ec2 Jun 14, 2023
whytewolf
whytewolf previously approved these changes Jun 14, 2023
@whytewolf
Copy link
Collaborator

looks like pre-commit failed. just needs black ran on it for a commit. Please update and that should take care of the issue.

@tryfunc tryfunc temporarily deployed to ci June 14, 2023 15:55 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 15:55 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 15:55 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 15:55 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 16:14 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 16:17 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 17:10 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 17:10 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 17:10 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 17:10 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 17:10 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 17:10 — with GitHub Actions Inactive
@tryfunc tryfunc force-pushed the hotfix/3006.x/fix-for-assume-role-in-salt-cloud-ec2 branch from 9f78a27 to f4149ab Compare June 14, 2023 17:36
tests/pytests/unit/utils/test_aws.py Outdated Show resolved Hide resolved
whytewolf
whytewolf previously approved these changes Jun 14, 2023
Ch3LL
Ch3LL previously approved these changes Jun 14, 2023
@tryfunc tryfunc dismissed stale reviews from Ch3LL and whytewolf via 27c0489 June 14, 2023 19:19
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 21:24 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 21:24 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci June 14, 2023 21:24 — with GitHub Actions Inactive
@tryfunc tryfunc force-pushed the hotfix/3006.x/fix-for-assume-role-in-salt-cloud-ec2 branch from b1f20b4 to 6a09dc4 Compare August 12, 2023 16:35
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 19:55 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 19:57 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 20:13 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 20:14 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 20:14 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 20:19 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 21:59 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 21:59 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 21:59 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 21:59 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 21:59 — with GitHub Actions Inactive
@tryfunc tryfunc temporarily deployed to ci August 14, 2023 21:59 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 19:12 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 19:12 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 19:12 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 19:17 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 19:28 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 19:35 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 20:49 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 20:49 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 20:49 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 20:49 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 20:49 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 15, 2023 20:49 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 4cada03 into saltstack:3006.x Aug 16, 2023
@welcome
Copy link

welcome bot commented Aug 16, 2023

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants