-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Fix for assume role when used salt-cloud to create aws ec2 #64481
[3006.x] Fix for assume role when used salt-cloud to create aws ec2 #64481
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
looks like pre-commit failed. just needs black ran on it for a commit. Please update and that should take care of the issue. |
9f78a27
to
f4149ab
Compare
b1f20b4
to
6a09dc4
Compare
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Fixes assuming role when used salt-cloud to create aws ec2.
What issues does this PR fix or reference?
Fixes: #52501
Previous Behavior
The repeated function call did not call the function assumed_creds, because in the case of a valid
__Expiration__
- active creds were returned (return __AccessKeyId__, __SecretAccessKey__, __Token__
) and the function execution was interrupted.New Behavior
The expression has been changed.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes