Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saltclass tops doesn't resolve __salt__ object functions #63863

Closed
wants to merge 0 commits into from

Conversation

paulbsd
Copy link

@paulbsd paulbsd commented Mar 11, 2023

What does this PR do?

Actually saltclass tops module doesn't resolve __salt__ object functions declared in saltclass pillar.
This fix resolves issue in latest stable version 3005.1.

What issues does this PR fix or reference?

Fixes: #50501

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@paulbsd paulbsd requested a review from a team as a code owner March 11, 2023 15:57
@paulbsd paulbsd requested review from twangboy and removed request for a team March 11, 2023 15:57
@welcome
Copy link

welcome bot commented Mar 11, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@paulbsd paulbsd closed this Aug 31, 2023
@s0undt3ch s0undt3ch temporarily deployed to nightly August 31, 2023 12:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly August 31, 2023 12:31 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 01:53 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:26 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 1, 2023 02:27 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:10 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:11 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:16 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to nightly September 5, 2023 07:37 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saltclass master_top module fails to populate __salt__ in some cases (salt-ssh + saltutil)
2 participants