Add state module queue setting from config and max limit #63357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasmhughes
requested review from
twangboy
and removed request for
a team
|
@nicholasmhughes Just a reminder if you wanted to get this in for 3006 the versionadded entries need to be updated. |
|
@garethgreenaway done! |
|
re-run pr-ubuntu-2004-amd64-py3-tcp-pytest |
garethgreenaway
approved these changes
Jan 6, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See issues for details.
What issues does this PR fix or reference?
Fixes: #31468
Fixed: #63356
Previous Behavior
Unable to set
queuefor state runs via configuration files.The
queue=Trueparameter to state module functions allows a new state run to be queued and wait for a run already in progress to complete before proceeding. However, there is currently no limit to how many runs will wait in the queue. If state runs are being performed on an interval and the runs take longer than the interval time, the queue could stack up indefinitely until the machine "falls over".New Behavior
Now able to set
queuefor state runs via thestate_queueconfiguration option.Allow the
queueparameter to be set to an integer, which will be checked against the current queue size. If the queue is greater than or equal to maximum, then that specific run will be treated as ifqueue=Falseand return a conflict.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.