-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#61650] Strip spaces from ssh config parameters #61652
[#61650] Strip spaces from ssh config parameters #61652
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
@0x416e746f6e Thanks for the PR, can you please add a file under the changelog directory with a short description of the fix. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with this change other than the changelog that @garethgreenaway requested.
6fb29b2
to
778ee9d
Compare
Since it was a small change, I went ahead and added a changelog file and migrated the test to the pytest directory. @garethgreenaway would you mind re-reviewing? |
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
What issues does this PR fix or reference?
Fixes: #61650
Previous Behavior
Previously it would pass the parameters from ssh config file as-is, with spaces/tabs in front of them.
New Behavior
The values of parameters are now stripped.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No