Bring win_lgpo changes in from master #55431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Let's split this into 2 or 3 PRs; it's too huge. |
twangboy
force-pushed
the
fix_win_lgpo_2019.2.3
branch
2 times, most recently
from
2d498ee to
93d482a
Compare
An empty REG_MULTI_SZ value was returning None instead of an empty list.
twangboy
force-pushed
the
fix_win_lgpo_2019.2.3
branch
from
24f0ae6 to
49e7503
Compare
- WindowsDefender.adml
Set the key to lowercase in the admx/adml files and cache those Change the REGKEY_XPATH back to no longer check for case Needs thorough testing
|
This is gunna be amazing. |
Adds a new function `get_policy` that allows you to get the current setting for a single policy on the machine. Adds some helper functions to get machine settings for policies defined in `_policy_info` (`_get_policy_info_setting`) and policies defined in the policy templates (`_get_policy_adm_setting`) Changes the `win_lgpo` state function to use `get_policy` instead of listing all policies and their settings on the machine. This is a huge speed increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Brings in changes from PR to master: #54896
Tests written?
Yes
Commits signed with GPG?
Yes