performance improvement: stop iterating runner dunder #53553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems some naive iterating of runners in salt.clients.mixin._low was causing all runners to be loaded non-lazily. this is slow and unneccessary, so we update globals on any already loaded mods and use the inject_globals decorator built into LazyLoader instead.
regardless of copying a function obj there is still only one __globals__. Lets just use the lazyloader decorator entirely instead.
DmitryKuzmenko
approved these changes
Jun 21, 2019
|
@DmitryKuzmenko should be to good now 👍 |
marbx
reviewed
Jun 28, 2019
There was a problem hiding this comment.
Hi @mattp,
congratulations, although I do not yet understand how lazy loading works.
Here you lazyload functions.
Would it also be possible to lazyload a dictionary?
I would like to lazyload grains, which are currently set with
self.opts['grains'] = salt.loader.grains(opts)
Thank you!
s0undt3ch
approved these changes
Apr 27, 2020
|
Oh good. |
|
@mattp- can you rebase this against master or perhaps there is another PR to reference, here? |
|
Closing as per author |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
seems some naive iterating of runners in salt.clients.mixin._low was
causing all runners to be loaded non-lazily. this is slow and
unneccessary, so we update globals on any already loaded mods and use
the inject_globals decorator built into LazyLoader instead.
this is particularly annoying if runners have noisy or slow virtual funcs.
Previous Behavior
runners loaded all runners all the time.
New Behavior
they are loaded lazily like minion mods
Tests written?
yes
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.