(Backport 53167) loader: support extra modules in sys.path #53440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynew
approved these changes
Jun 13, 2019
waynew
added
pending-changes
cmcmarrow
approved these changes
Jun 14, 2019
Akm0d
approved these changes
Jun 14, 2019
|
re-run all |
|
@aplanas is there any way that these git test failures
are related to this change? It seems unlikely to me without further digging, and weird that it's just these couple of platforms on which it's failing... 🤷♂ |
|
@waynew I rebased the code, to relaunch the CI |
(cherry picked from commit bb798685d29261f5dc290ba08694214be2204a7a)
(cherry picked from commit f7b0c8b68470256de225bee7343ff21c9af8cc60)
(cherry picked from commit 5a8a0ce3c3f1d27f7ae55167df8c98d021873f9e)
The LazyLoader class populate the sys.path array to add the path that contains the Python module that will be executed. If before this point sys.path gets extended (like when globally the extmods utils directory in added in some places, like after a sync) the code can find all the dependencies. This patch adds a new parameter to the LazyLoader class, extra_module_dirs, that will populate locally the sys.path before executing the the module. This can be used to guarantee that in utils (and other modules) will be available to the modules and states in any circumstances and Python process. (cherry picked from commit 670974f9d7e95a030a1429b3abe2e75873ebb3b6)
This reverts commit 7e82f3e. (cherry picked from commit e0e5c282583db7fd3ba4d21bcfadf30943f04ab7)
aplanas
force-pushed
the
backport_53167
branch
from
b30a1c9 to
b23f6b4
Compare
|
Rebased on master as part of #53167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The LazyLoader class populate the sys.path array to add the path
that contains the Python module that will be executed. If before
this point sys.path gets extended (like when globally the extmods
utils directory in added in some places, like after a sync) the
code can find all the dependencies.
This patch adds a new parameter to the LazyLoader class,
extra_module_dirs, that will populate locally the sys.path before
executing the the module.
This can be used to guarantee that in utils (and other modules) will be
available to the modules and states in any circumstances and Python
process.
Tests written?
Yes
(backport #53167)