Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force the default configs to be immutable #51245

Merged
merged 5 commits into from
Jan 19, 2019
Merged

Force the default configs to be immutable #51245

merged 5 commits into from
Jan 19, 2019

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

See title.

Commits signed with GPG?

Yes

@s0undt3ch s0undt3ch requested a review from a team as a code owner January 18, 2019 17:11
@s0undt3ch s0undt3ch force-pushed the features/immutable-default-config branch from 4cc843b to a15aa83 Compare January 18, 2019 17:12
@s0undt3ch s0undt3ch mentioned this pull request Jan 18, 2019
Merged
@twangboy
Copy link
Contributor

We should probably add this to a linter...

@s0undt3ch
Copy link
Collaborator Author

What exactly?
After this is merged, you won't be able to change anything on those default dictionaries, unless you .copy() them.

@s0undt3ch
Copy link
Collaborator Author

One core dev approval. Merging.

@s0undt3ch s0undt3ch merged commit acf2328 into saltstack:develop Jan 19, 2019
@s0undt3ch s0undt3ch deleted the features/immutable-default-config branch January 19, 2019 18:25
@s0undt3ch s0undt3ch mentioned this pull request Nov 25, 2019
Merged
@s0undt3ch s0undt3ch added the has master-port port to master has been created label Nov 25, 2019
@s0undt3ch
Copy link
Collaborator Author

Master port in #55423

dwoz added a commit that referenced this pull request Nov 29, 2019
@dwoz
Merge pull request #55423 from s0undt3ch/hotfix/immutable-config
4977f17 
Port #51245 to master
@max-arnold max-arnold mentioned this pull request Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

Assignees
No one assigned
Labels
has master-port port to master has been created
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s0undt3ch @twangboy