-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying SET in createFunction #1233
Merged
Shinigami92
merged 7 commits into
salsita:main
from
axelrindle:feat/create-function/set-configuration-parameter
Jul 27, 2024
Merged
feat: allow specifying SET in createFunction #1233
Shinigami92
merged 7 commits into
salsita:main
from
axelrindle:feat/create-function/set-configuration-parameter
Jul 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
reviewed
Jul 26, 2024
Please also add a integration test in |
Co-authored-by: Shinigami <[email protected]>
Shinigami92
reviewed
Jul 26, 2024
I will potentially have a look tomorrow and see if I can merge and release this (together with Renovate updates) |
Shinigami92
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a change to the
createFunction
function.It will allow specifiying
SET
statements to change configuration parameters as stated in the official specification.I encountered this while using Supabase: https://supabase.com/docs/guides/database/database-advisors?queryGroups=lint&lint=0011_function_search_path_mutable#how-to-resolve