feat(functions): support security #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
force-pushed
the
feat-support-create-function-security
branch
from
015cd98 to
8f99b73
Compare
|
@therealsujitk please make a review and approve if everything looks fine to you |
therealsujitk
suggested changes
May 29, 2024
There was a problem hiding this comment.
LGTM!
- I personally don't like the migrations test case (didn't know Postgress doesn't throw an error if the table doesn't exist), but I guess it should be fine. You can ignore this.
- One other thing, I think the docs should be updated to include this property.
Oh my god, thank you The integration test case is just as nearly as possible to https://www.postgresql.org/docs/current/sql-createfunction.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1175