Table unique constraint can be array of arrays (#126)

salsita · Oct 9, 2017 · 26c0faf · 26c0faf
1 parent 78fa3ef
commit 26c0faf
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 2 deletions.
diff --git a/lib/operations/tables.js b/lib/operations/tables.js
@@ -108,7 +108,15 @@ const parseConstraints = (table, options) => {
     constraints.push(`CONSTRAINT "${table_name}_chck" CHECK (${check})`);
   }
   if (unique) {
-    constraints.push(`CONSTRAINT "${table_name}_uniq" UNIQUE (${quote(_.isArray(unique) ? unique : [unique]).join(', ')})`);
+    const uniqueArray = _.isArray(unique) ? unique : [unique];
+    const isArrayOfArrays = uniqueArray.some(uniqueSet => _.isArray(uniqueSet));
+    if (isArrayOfArrays) {
+      uniqueArray.forEach((uniqueSet, i) =>
+        constraints.push(`CONSTRAINT "${table_name}_uniq_${i + 1}" UNIQUE (${quote(_.isArray(uniqueSet) ? uniqueSet : [uniqueSet]).join(', ')})`)
+      );
+    } else {
+      constraints.push(`CONSTRAINT "${table_name}_uniq" UNIQUE (${quote(uniqueArray).join(', ')})`);
+    }
   }
   if (primaryKey) {
     constraints.push(`CONSTRAINT "${table_name}_pkey" PRIMARY KEY (${quote(_.isArray(primaryKey) ? primaryKey : [primaryKey]).join(', ')})`);

diff --git a/test/tables-test.js b/test/tables-test.js
@@ -25,7 +25,12 @@ describe('lib/operations/tables', () => {
     });
 
     it('check schemas can be used for foreign keys', () => {
-      const sql = Tables.create()('my_table_name', { parent_id: { type: 'integer', references: { schema: 'a', name: 'b' } } });
+      const sql = Tables.create()('my_table_name', {
+        parent_id: {
+          type: 'integer',
+          references: { schema: 'a', name: 'b' }
+        }
+      });
       expect(sql).to.equal(`CREATE TABLE "my_table_name" (
   "parent_id" integer REFERENCES "a"."b" MATCH SIMPLE
 );`);
@@ -72,6 +77,52 @@ describe('lib/operations/tables', () => {
   "a" integer,
   "b" varchar,
   FOREIGN KEY ("a", "b") REFERENCES otherTable (A, B) MATCH SIMPLE
+);`);
+    });
+
+    it('check table unique constraint work correctly', () => {
+      const sql = Tables.create()(
+        'my_table_name',
+        {
+          a: { type: 'integer' },
+          b: { type: 'varchar' },
+        },
+        {
+          constraints: {
+            unique: ['a', 'b'],
+          },
+        }
+      );
+      expect(sql).to.equal(`CREATE TABLE "my_table_name" (
+  "a" integer,
+  "b" varchar,
+  CONSTRAINT "my_table_name_uniq" UNIQUE ("a", "b")
+);`);
+    });
+
+    it('check table unique constraint work correctly for array of arrays', () => {
+      const sql = Tables.create()(
+        'my_table_name',
+        {
+          a: { type: 'integer' },
+          b: { type: 'varchar' },
+          c: { type: 'varchar' },
+        },
+        {
+          constraints: {
+            unique: [
+              ['a', 'b'],
+              'c',
+            ],
+          },
+        }
+      );
+      expect(sql).to.equal(`CREATE TABLE "my_table_name" (
+  "a" integer,
+  "b" varchar,
+  "c" varchar,
+  CONSTRAINT "my_table_name_uniq_1" UNIQUE ("a", "b"),
+  CONSTRAINT "my_table_name_uniq_2" UNIQUE ("c")
 );`);
     });
   });