-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUPDESQ-34] added schema and linked field to vocab #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tino097
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MarkCalvert
reviewed
Nov 25, 2021
9ceaab6
to
4359f4e
Compare
MarkCalvert
approved these changes
Dec 19, 2021
MarkCalvert
added a commit
that referenced
this pull request
May 25, 2022
* [SUPDESQ-34] added schema and linked field to vocab (#33) * [SUPDESQ-34] added new col and its cli comand * [SUPDESQ-34] added schema and linked field to vocab * [SUPDESQ-34] updated option and added validator * [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown * [SUPDESQ-34] - added migration script * [SUPDESQ-34] - fix downgrade command * [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible * [SUPDESQ-34] remove update db cmd * [SUPDESQ-35] - added support for quantity kind (#34) * [SUPDESQ-34] added new col and its cli comand * [SUPDESQ-34] added schema and linked field to vocab * [SUPDESQ-34] updated option and added validator * [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown * [SUPDESQ-34] - added migration script * [SUPDESQ-34] - fix downgrade command * [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible * [SUPDESQ-34] remove update db cmd * [SUPDESQ-35] - added support for quantity kind Co-authored-by: Mark Calvert <[email protected]> * [SUPDESQ-34] - fix issue with dropdown rendering issue (#35) * [SUPDESQ-34] - added default value to js (#36) * [SUPDESQ-34] rendered label for the field name * [SUPDESQ-34] updated validation logic * Squashed commit of the following: commit 6afa95f Author: Mark Calvert <[email protected]> Date: Wed May 18 13:48:00 2022 +1200 [SUPDESQ-35] Refactored `vocabulary_service_term_upsert` code Updated existing_term to use label and uri has the key for allow_duplicate_terms Refactored code for existing terms to update if there are any changes commit e7a51aa Merge: 41ab3bc cbd8123 Author: Mark Calvert <[email protected]> Date: Wed May 18 13:43:11 2022 +1200 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 41ab3bc Merge: 36d1aa0 dcbb949 Author: Mark Calvert <[email protected]> Date: Mon Dec 20 10:43:57 2021 +1300 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 36d1aa0 Author: awang setyawan <[email protected]> Date: Mon Dec 6 07:29:26 2021 +0700 [SUPDESQ-35] - added support for quantity kind commit f5c2029 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:15:59 2021 +0700 [SUPDESQ-34] remove update db cmd commit 7774cb2 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:09:26 2021 +0700 [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible commit 8209c65 Author: awang setyawan <[email protected]> Date: Sat Dec 4 20:16:45 2021 +0700 [SUPDESQ-34] - fix downgrade command commit 4359f4e Author: awang setyawan <[email protected]> Date: Wed Dec 1 08:06:59 2021 +0700 [SUPDESQ-34] - added migration script commit 8a80db6 Author: awang setyawan <[email protected]> Date: Sun Nov 28 07:55:41 2021 +0700 [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown commit 4fd90e8 Author: awang setyawan <[email protected]> Date: Tue Nov 16 12:46:48 2021 +0700 [SUPDESQ-34] updated option and added validator commit 9081b74 Author: awang setyawan <[email protected]> Date: Mon Nov 15 12:49:09 2021 +0700 [SUPDESQ-34] added schema and linked field to vocab commit 84130cf Author: awang setyawan <[email protected]> Date: Tue Nov 2 15:01:30 2021 +0700 [SUPDESQ-34] added new col and its cli comand * Squashed commit of the following: (#38) commit 6afa95f Author: Mark Calvert <[email protected]> Date: Wed May 18 13:48:00 2022 +1200 [SUPDESQ-35] Refactored `vocabulary_service_term_upsert` code Updated existing_term to use label and uri has the key for allow_duplicate_terms Refactored code for existing terms to update if there are any changes commit e7a51aa Merge: 41ab3bc cbd8123 Author: Mark Calvert <[email protected]> Date: Wed May 18 13:43:11 2022 +1200 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 41ab3bc Merge: 36d1aa0 dcbb949 Author: Mark Calvert <[email protected]> Date: Mon Dec 20 10:43:57 2021 +1300 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 36d1aa0 Author: awang setyawan <[email protected]> Date: Mon Dec 6 07:29:26 2021 +0700 [SUPDESQ-35] - added support for quantity kind commit f5c2029 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:15:59 2021 +0700 [SUPDESQ-34] remove update db cmd commit 7774cb2 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:09:26 2021 +0700 [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible commit 8209c65 Author: awang setyawan <[email protected]> Date: Sat Dec 4 20:16:45 2021 +0700 [SUPDESQ-34] - fix downgrade command commit 4359f4e Author: awang setyawan <[email protected]> Date: Wed Dec 1 08:06:59 2021 +0700 [SUPDESQ-34] - added migration script commit 8a80db6 Author: awang setyawan <[email protected]> Date: Sun Nov 28 07:55:41 2021 +0700 [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown commit 4fd90e8 Author: awang setyawan <[email protected]> Date: Tue Nov 16 12:46:48 2021 +0700 [SUPDESQ-34] updated option and added validator commit 9081b74 Author: awang setyawan <[email protected]> Date: Mon Nov 15 12:49:09 2021 +0700 [SUPDESQ-34] added schema and linked field to vocab commit 84130cf Author: awang setyawan <[email protected]> Date: Tue Nov 2 15:01:30 2021 +0700 [SUPDESQ-34] added new col and its cli comand * Added quantity_kind field value to action vocabulary_service_term_create Co-authored-by: Awang <[email protected]> Co-authored-by: Konstantin Sivakov <[email protected]>
MarkCalvert
added a commit
that referenced
this pull request
Oct 5, 2022
* [SUPDESQ-34] added schema and linked field to vocab (#33) * [SUPDESQ-34] added new col and its cli comand * [SUPDESQ-34] added schema and linked field to vocab * [SUPDESQ-34] updated option and added validator * [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown * [SUPDESQ-34] - added migration script * [SUPDESQ-34] - fix downgrade command * [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible * [SUPDESQ-34] remove update db cmd * [SUPDESQ-35] - added support for quantity kind (#34) * [SUPDESQ-34] added new col and its cli comand * [SUPDESQ-34] added schema and linked field to vocab * [SUPDESQ-34] updated option and added validator * [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown * [SUPDESQ-34] - added migration script * [SUPDESQ-34] - fix downgrade command * [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible * [SUPDESQ-34] remove update db cmd * [SUPDESQ-35] - added support for quantity kind Co-authored-by: Mark Calvert <[email protected]> * [SUPDESQ-34] - fix issue with dropdown rendering issue (#35) * [SUPDESQ-34] - added default value to js (#36) * [SUPDESQ-34] rendered label for the field name * [SUPDESQ-34] updated validation logic * Squashed commit of the following: commit 6afa95f Author: Mark Calvert <[email protected]> Date: Wed May 18 13:48:00 2022 +1200 [SUPDESQ-35] Refactored `vocabulary_service_term_upsert` code Updated existing_term to use label and uri has the key for allow_duplicate_terms Refactored code for existing terms to update if there are any changes commit e7a51aa Merge: 41ab3bc cbd8123 Author: Mark Calvert <[email protected]> Date: Wed May 18 13:43:11 2022 +1200 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 41ab3bc Merge: 36d1aa0 dcbb949 Author: Mark Calvert <[email protected]> Date: Mon Dec 20 10:43:57 2021 +1300 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 36d1aa0 Author: awang setyawan <[email protected]> Date: Mon Dec 6 07:29:26 2021 +0700 [SUPDESQ-35] - added support for quantity kind commit f5c2029 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:15:59 2021 +0700 [SUPDESQ-34] remove update db cmd commit 7774cb2 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:09:26 2021 +0700 [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible commit 8209c65 Author: awang setyawan <[email protected]> Date: Sat Dec 4 20:16:45 2021 +0700 [SUPDESQ-34] - fix downgrade command commit 4359f4e Author: awang setyawan <[email protected]> Date: Wed Dec 1 08:06:59 2021 +0700 [SUPDESQ-34] - added migration script commit 8a80db6 Author: awang setyawan <[email protected]> Date: Sun Nov 28 07:55:41 2021 +0700 [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown commit 4fd90e8 Author: awang setyawan <[email protected]> Date: Tue Nov 16 12:46:48 2021 +0700 [SUPDESQ-34] updated option and added validator commit 9081b74 Author: awang setyawan <[email protected]> Date: Mon Nov 15 12:49:09 2021 +0700 [SUPDESQ-34] added schema and linked field to vocab commit 84130cf Author: awang setyawan <[email protected]> Date: Tue Nov 2 15:01:30 2021 +0700 [SUPDESQ-34] added new col and its cli comand * Squashed commit of the following: (#38) commit 6afa95f Author: Mark Calvert <[email protected]> Date: Wed May 18 13:48:00 2022 +1200 [SUPDESQ-35] Refactored `vocabulary_service_term_upsert` code Updated existing_term to use label and uri has the key for allow_duplicate_terms Refactored code for existing terms to update if there are any changes commit e7a51aa Merge: 41ab3bc cbd8123 Author: Mark Calvert <[email protected]> Date: Wed May 18 13:43:11 2022 +1200 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 41ab3bc Merge: 36d1aa0 dcbb949 Author: Mark Calvert <[email protected]> Date: Mon Dec 20 10:43:57 2021 +1300 Merge branch 'develop' into feature/SUPDESQ-35-quantity_kind commit 36d1aa0 Author: awang setyawan <[email protected]> Date: Mon Dec 6 07:29:26 2021 +0700 [SUPDESQ-35] - added support for quantity kind commit f5c2029 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:15:59 2021 +0700 [SUPDESQ-34] remove update db cmd commit 7774cb2 Author: awang setyawan <[email protected]> Date: Sat Dec 18 11:09:26 2021 +0700 [SUPDESQ-34] fix updated screen and prevent secure vocab to be visible commit 8209c65 Author: awang setyawan <[email protected]> Date: Sat Dec 4 20:16:45 2021 +0700 [SUPDESQ-34] - fix downgrade command commit 4359f4e Author: awang setyawan <[email protected]> Date: Wed Dec 1 08:06:59 2021 +0700 [SUPDESQ-34] - added migration script commit 8a80db6 Author: awang setyawan <[email protected]> Date: Sun Nov 28 07:55:41 2021 +0700 [SUPDESQ-34] - enable select2 autocomplete and fix field group dropdown commit 4fd90e8 Author: awang setyawan <[email protected]> Date: Tue Nov 16 12:46:48 2021 +0700 [SUPDESQ-34] updated option and added validator commit 9081b74 Author: awang setyawan <[email protected]> Date: Mon Nov 15 12:49:09 2021 +0700 [SUPDESQ-34] added schema and linked field to vocab commit 84130cf Author: awang setyawan <[email protected]> Date: Tue Nov 2 15:01:30 2021 +0700 [SUPDESQ-34] added new col and its cli comand * Added quantity_kind field value to action vocabulary_service_term_create Co-authored-by: Awang <[email protected]> Co-authored-by: Konstantin Sivakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://salsadigital.atlassian.net/browse/SUPDESQ-34
