Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to axe v4 #34

Merged
merged 25 commits into from
Aug 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7ed664e
build: update axe to v4
mohanraj-r Aug 5, 2020
07ebcc3
test: update axe help urls in snapshots for axe v4 update
mohanraj-r Aug 5, 2020
3aff021
build: refactor out direct dependency on graphviz-cli
mohanraj-r Aug 10, 2020
3dee163
build: update dependencies to latest versions
mohanraj-r Aug 10, 2020
66c6515
build: update dependencies
mohanraj-r Aug 13, 2020
30d5a6c
test(rules): remove rules that have been removed in axe v4
mohanraj-r Aug 13, 2020
ab339d5
test(lint): remove suppression for axe version
mohanraj-r Aug 13, 2020
94358dd
docs: move dependency graph to docs dir
mohanraj-r Aug 13, 2020
578fddc
docs: update info reg dep graph generation
mohanraj-r Aug 13, 2020
c60f095
docs: fix link to dep graph
mohanraj-r Aug 13, 2020
b5437b4
build: update axe to v4
mohanraj-r Aug 5, 2020
0fcc58a
test: update axe help urls in snapshots for axe v4 update
mohanraj-r Aug 5, 2020
e7637db
build: refactor out direct dependency on graphviz-cli
mohanraj-r Aug 10, 2020
8246a2e
build: update dependencies to latest versions
mohanraj-r Aug 10, 2020
557f75d
build: update dependencies
mohanraj-r Aug 13, 2020
90ea322
test(rules): remove rules that have been removed in axe v4
mohanraj-r Aug 13, 2020
cd4a0e7
test(lint): remove suppression for axe version
mohanraj-r Aug 13, 2020
604eb7b
docs: move dependency graph to docs dir
mohanraj-r Aug 13, 2020
7e42bb4
docs: update info reg dep graph generation
mohanraj-r Aug 13, 2020
7c85a42
docs: fix link to dep graph
mohanraj-r Aug 13, 2020
050488f
build: pin version of commitlint due to a bug in the latest release
mohanraj-r Aug 19, 2020
8030ea3
docs: update dep graph after rebase on master
mohanraj-r Aug 19, 2020
b3287b4
ci: fix glob patterns of generated files
mohanraj-r Aug 19, 2020
3fef0b7
Merge remote-tracking branch 'mohanraj-r/upgrade_axe_4' into upgrade_…
mohanraj-r Aug 19, 2020
e920ba7
docs: update version, changelog for v0.3.1
mohanraj-r Aug 19, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
# Mark generated files
yarn.lock linguist-generated=true
# generated JS files
dist/* linguist-generated=true
**/dist/** linguist-generated=true
# jest snapshots
*.test.ts.snap linguist-generated=true
**/__snapshots__/** linguist-generated=true
# dependency graph
docs/sa11y_dependency_graph.svg linguist-generated=true
16 changes: 12 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->


- [0.3.0-beta (2020-08-12)](#030-beta-2020-08-12)
- [0.3.1-beta](#031-beta)
- [Refactor](#refactor)
- [0.3.0-beta (2020-08-19)](#030-beta-2020-08-19)
- [Features](#features)
- [0.2.0-beta (2020-06-25)](#020-beta-2020-06-25)
- [Features](#features-1)
- [Bug Fixes](#bug-fixes)
- [BREAKING CHANGES](#breaking-changes)
- [(2020-06-02) v0.1.0-alpha](#2020-06-02-v010-alpha)
- [v0.1.0-alpha (2020-06-02)](#v010-alpha-2020-06-02)
- [Features](#features-2)
- [(2020-05-29)](#2020-05-29)
- [Features](#features-3)
Expand All @@ -26,7 +28,13 @@

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

# 0.3.0-beta (2020-08-12)
# [0.3.1-beta](2020-08-19)

### Refactor

- chore: update to the latest major release of axe

# [0.3.0-beta](https://github.com/salesforce/sa11y/tree/v0.3.0-beta) (2020-08-19)

### Features

Expand Down Expand Up @@ -57,7 +65,7 @@
- If you are using the `recommended` preset-rule rename it to `base`
- If you are using the `extended` preset-rule rename it to `recommended`

# (2020-06-02) [v0.1.0-alpha](https://github.com/salesforce/sa11y/releases/tag/v0.1.0-alpha)
# [v0.1.0-alpha](https://github.com/salesforce/sa11y/releases/tag/v0.1.0-alpha) (2020-06-02)

### Features

Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ We want to encourage the developer community to contribute to Sa11y. This guide
- [Create a feature branch](#create-a-feature-branch)
- [Make your changes](#make-your-changes)
- [Media files](#media-files)
- [Update dependency graph](#update-dependency-graph)
- [Update dependency graph](#update-dependency-graph)
- [Rebase](#rebase)
- [Check your submission](#check-your-submission)
- [Lint your changes](#lint-your-changes)
Expand Down Expand Up @@ -229,10 +229,10 @@ request.

Media files such as screenshots, images and demo videos are uploaded into a separate `media` branch. The uploaded files are then linked/referenced from the `media` branch to the other branches. This helps [manage the binary assets separately](https://gist.github.com/joncardasis/e6494afd538a400722545163eb2e1fa5) without bloating the history/size of the main repo.

##### Update dependency graph
#### Update dependency graph

- Generate dependency graph using `yarn pkg:depgraph`
- Copy the generated file over to the `media` branch
- Check if dependency graph needs to be updated using `yarn lint:depgraph`

### Rebase

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ This repo contains the following packages for automated accessibility testing:

### Dependency graph

![Dependency graph of sa11y packages](https://github.com/salesforce/sa11y/blob/media/architecture/sa11y_dependency_graph.svg?raw=true)
![Dependency graph of sa11y packages](docs/sa11y_dependency_graph.svg)

---

Expand Down
192 changes: 192 additions & 0 deletions docs/sa11y_dependency_graph.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 5 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sa11y-monorepo",
"version": "0.3.0-beta",
"version": "0.3.1-beta",
"private": true,
"description": "Salesforce Accessibility Automated Testing Libraries and Tools (@sa11y packages)",
"license": "BSD-3-Clause",
Expand All @@ -25,14 +25,14 @@
"lint": "eslint . --ext ts,js,md",
"lint:all": "yarn lint && yarn lint:lockfile && yarn lint:deps && yarn lint:depgraph",
"lint:deps": "lerna exec depcheck",
"lint:depgraph": "yarn pkg:depgraph; git diff --quiet origin/media:architecture/sa11y_dependency_graph.svg ./sa11y_dependency_graph.svg && rm ./sa11y_dependency_graph.svg",
"lint:depgraph": "yarn pkg:depgraph; git diff --quiet docs/sa11y_dependency_graph.svg || echo 'Dependency graph needs to be updated!'",
"lint:fix": "yarn lint --fix",
"lint:lockfile": "lockfile-lint --path yarn.lock --allowed-hosts registry.yarnpkg.com --validate-https",
"lint:staged": "lint-staged",
"lint:watch": "esw --watch --changed --color --ext .js,.ts",
"pkg:list": "lerna list --long --all --toposort",
"pkg:deps": "yarn pkg:list --graph",
"pkg:depgraph": "yarn package-dependency-graph --dot sa11y_dependency_graph.dot; graphviz -Tsvg sa11y_dependency_graph.dot > sa11y_dependency_graph.svg; rm sa11y_dependency_graph.dot",
"pkg:depgraph": "yarn package-dependency-graph --graphviz --svg docs/sa11y_dependency_graph.svg",
"release:changelog": "conventional-changelog --infile CHANGELOG.md --same-file --preset angular --output-unreleased",
"release:version": "yarn lerna version --no-push --no-git-tag-version",
"release:version:auto": "yarn release:version --conventional-commits --no-changelog",
Expand Down Expand Up @@ -62,8 +62,8 @@
"@babel/core": "^7.11.1",
"@babel/preset-env": "^7.11.0",
"@babel/preset-typescript": "^7.10.4",
"@commitlint/cli": "^9.1.1",
"@commitlint/config-conventional": "^9.1.1",
"@commitlint/cli": "9.1.1",
"@commitlint/config-conventional": "9.1.1",
"@types/jest": "^26.0.10",
"@types/node": "^14.6.0",
"@typescript-eslint/eslint-plugin": "^2.33.0",
Expand Down Expand Up @@ -93,7 +93,6 @@
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-tsdoc": "^0.2.6",
"eslint-watch": "^7.0.0",
"graphviz-cli": "^1.0.0",
"husky": "^4.2.5",
"jest": "^26.4.0",
"lerna": "^3.21.0",
Expand Down
22 changes: 11 additions & 11 deletions packages/assert/__tests__/__snapshots__/assert.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/assert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@sa11y/common": "0.2.0-beta.0",
"@sa11y/format": "0.2.1-beta.0",
"@sa11y/preset-rules": "0.2.0-beta.0",
"axe-core": "3.5.5"
"axe-core": "4.0.1"
},
"devDependencies": {
"@sa11y/test-utils": "0.2.0-beta.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dist/**/*.js"
],
"dependencies": {
"axe-core": "3.5.5"
"axe-core": "4.0.1"
},
"publishConfig": {
"access": "public"
Expand Down
Loading