chore: update to axe v4 #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the new version of package-dependency-graph includes graphviz support
as the type def has been fixed in axe v4
* TODO: remove file from media branch
mohanraj-r
commented
Aug 13, 2020
| @@ -17,16 +17,11 @@ describe('preset-rules', () => { | |||
| // or due to their experimental nature | |||
| const excludedRules = [ | |||
| /* cSpell:disable */ | |||
| 'aria-dpub-role-fallback', | |||
There was a problem hiding this comment.
@cordeliadillon Changes in this file to remove rules that have been removed from axe v4 along with updating help urls of a11y results in test snapshots were the primary changes to upgrade to axe v4. Can you please review.
There was a problem hiding this comment.
The removed rules match https://github.com/dequelabs/axe-core/releases/tag/v4.0.0
The following rules were deprecated in axe-core 3.x, and are removed in 4.0:
aria-dpub-role-fallback
checkboxgroup
layout-table
radiogroup
video-description
as the new version of package-dependency-graph includes graphviz support
as the type def has been fixed in axe v4
* TODO: remove file from media branch
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 14
Lines ? 112
Branches ? 11
==========================================
Hits ? 112
Misses ? 0
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated as #34 due to not force-pushing after doing rebase and incorrect diff showing up in this PR as a result
Primary changes
axe.versionas the type def has been fixed in axe v4 (ab339d5)mediabranch to feature branchmediabranchmediabranch and also doesn't take much space (~10kb) so it shouldn't bloat feature branchesTODO
Post merge
origin/media:architecture/sa11y_dependency_graph.svgafter merge to master